Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events on styled components are typed as any #43

Closed
peduarte opened this issue Jul 8, 2020 · 3 comments · Fixed by #272
Closed

events on styled components are typed as any #43

peduarte opened this issue Jul 8, 2020 · 3 comments · Fixed by #272
Labels
bug Something isn't working typescript TypeScript related

Comments

@peduarte
Copy link
Contributor

peduarte commented Jul 8, 2020 •
edited
Loading

In this example, Button is the return of styled.button

CleanShot 2020-07-08 at 11 47 55@2x
@peduarte peduarte changed the title as prop not typing events events on styled components are typed as any Jul 8, 2020
@kripod
Copy link

kripod commented Jul 8, 2020 •
edited
Loading

Yeah, it’s definitely an issue with react-polymorphic-box and I vaguely remember that TypeScript 4 had something on its roadmap to resolve the situation…

@kripod
Copy link

kripod commented Jul 8, 2020

This should be fixed on the language level of TypeScript, as far as I know: microsoft/TypeScript#31023

@peduarte
Copy link
Contributor Author

peduarte commented Jul 8, 2020

@kripod ah nice, thanks for chiming in. I wasn't sure if this was directly related to react-polymorphic-box or not.
I also created this, which could be related: #44

@peduarte peduarte mentioned this issue Jul 8, 2020
Closed
@kripod kripod mentioned this issue Jul 15, 2020
Closed
@peduarte peduarte added the bug Something isn't working label Aug 4, 2020
@peduarte peduarte added the typescript TypeScript related label Sep 18, 2020
@hadihallak hadihallak mentioned this issue Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix events types on Styled components stitchesjs/stitches
2 participants
@peduarte @kripod