Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try It: Allow selecting parameter enums & examples #645

Closed
marbemac opened this issue Oct 19, 2020 · 4 comments · Fixed by #755
Closed

Try It: Allow selecting parameter enums & examples #645

marbemac opened this issue Oct 19, 2020 · 4 comments · Fixed by #755
Assignees
Labels
commit/2020-12-15 Commitment for Sprint 2020-12-15 team/undefined
Milestone

Comments

@marbemac
Copy link
Contributor

marbemac commented Oct 19, 2020

Design: https://www.figma.com/proto/IkNc59AU2JN5Kc1qbd2AiB/Elements?node-id=97%3A517&viewport=2242%2C501%2C1.1532831192016602&scaling=min-zoom

As a docs consumer, I can choose from a list of enums and examples when filling values in the request parameters.

  • If a parameter has enums defined, make the parameter value input a dropdown. See the "location" property in the linked design.

  • If the parameter is a number, use a number input so that the user can only input a number. text box is editable.

  • If a parameter has examples, for now just set the initial value to to the first example (no dropdown or anything). text box is editable

  • If a parameter has a default value, show the default in the placeholder. text box is editable.

  • If the value is a boolean, use a dropdown with "Not Set", "True", and "False" as the options.

@marbemac
Copy link
Contributor Author

@marbemac marbemac changed the title Allow selecting parameter enums & examples Try It: Allow selecting parameter enums & examples Nov 3, 2020
@marcelltoth
Copy link
Contributor

Examples:

If there's a single example, show a textbox pre-populated with the single example.

If there are multiple ones, show a dropdown that allows you to still input a custom value.

@marcelltoth marcelltoth added this to the 2020-12-01 milestone Dec 1, 2020
@mallachari mallachari self-assigned this Dec 4, 2020
@marcelltoth marcelltoth modified the milestones: 2020-12-01, 2020-12-15 Dec 15, 2020
@philsturgeon
Copy link
Contributor

@marcelltoth I think we unblocked this one by splitting the work in half, did we make a new issue for that? Anything holding up the merge?

@marcelltoth
Copy link
Contributor

@philsturgeon

  1. Just created the followup, see Upgrade to the new mosaic Select/Dropdown #769
  2. Check the PR (feat: parameters inputs #755)

@marcelltoth marcelltoth added the commit/2020-12-15 Commitment for Sprint 2020-12-15 label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit/2020-12-15 Commitment for Sprint 2020-12-15 team/undefined
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants