Skip to content

Commit

Permalink
test: Skip WalletTests.WalletNetworkSerialization
Browse files Browse the repository at this point in the history
It suffers from a race condition when `zcash-gtest` runs tests in
parallel, because it depends on the global network parameters being
stable across the whole test. Other tests changing the parameters from
underneath it cause the test to fail in weird and wonderful ways.
  • Loading branch information
str4d committed Jun 23, 2023
1 parent 62cf3f5 commit 8beacc2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/wallet/gtest/test_wallet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ TEST(WalletTests, SetupDatadirLocationRunAsFirstTest) {
}

TEST(WalletTests, WalletNetworkSerialization) {
GTEST_SKIP() << "Skipping because it has a race condition and cannot be run in parallel.";
SelectParams(CBaseChainParams::TESTNET);

// Get temporary and unique path for file.
Expand Down

0 comments on commit 8beacc2

Please sign in to comment.