From 8beacc20125a5c905ea552de6dbd558e7c1e6e2d Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Tue, 20 Jun 2023 20:10:45 +0000 Subject: [PATCH] test: Skip `WalletTests.WalletNetworkSerialization` It suffers from a race condition when `zcash-gtest` runs tests in parallel, because it depends on the global network parameters being stable across the whole test. Other tests changing the parameters from underneath it cause the test to fail in weird and wonderful ways. --- src/wallet/gtest/test_wallet.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wallet/gtest/test_wallet.cpp b/src/wallet/gtest/test_wallet.cpp index b4aa3d2f004..0b4f080d03c 100644 --- a/src/wallet/gtest/test_wallet.cpp +++ b/src/wallet/gtest/test_wallet.cpp @@ -138,6 +138,7 @@ TEST(WalletTests, SetupDatadirLocationRunAsFirstTest) { } TEST(WalletTests, WalletNetworkSerialization) { + GTEST_SKIP() << "Skipping because it has a race condition and cannot be run in parallel."; SelectParams(CBaseChainParams::TESTNET); // Get temporary and unique path for file.