Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_FixedOffset Base Class #82

Open
AlecRosenbaum opened this issue Sep 2, 2022 · 0 comments
Open

_FixedOffset Base Class #82

AlecRosenbaum opened this issue Sep 2, 2022 · 0 comments

Comments

@AlecRosenbaum
Copy link

While most timezone classes share a BaseTzInfo class, _FixedOffset does not. Functionally it doesn't really make a difference, but with stricter type checking it can become troublesome. Some interfaces from third-party projects specify BaseTzInfo within type annotations where _FixedOffset should also work.

Would you be open to a change that just replaces class _FixedOffset(datetime.tzinfo): with class _FixedOffset(BaseTzInfo):?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlecRosenbaum