Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing Image Masking: Configurable Default Color Selection #20

Closed
sumn2u opened this issue Jun 10, 2024 · 2 comments · Fixed by #21
Closed

Enhancing Image Masking: Configurable Default Color Selection #20

sumn2u opened this issue Jun 10, 2024 · 2 comments · Fixed by #21
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs

Comments

@sumn2u
Copy link
Owner

sumn2u commented Jun 10, 2024

Currently, when masking the image, a default black color is selected.

image

Update the logic to allow this value to be loaded from a configuration file.

@sumn2u sumn2u added enhancement New feature or request good first issue Good for newcomers up for grabs labels Jun 10, 2024
@Mews
Copy link
Contributor

Mews commented Jun 10, 2024

@sumn2u
Since it wasn't supper clear, is there an existing configuration file where this value should be loaded from, or is creating a configuration file also required? And if so, where should It be located, and do you have any preferences for the file format

@sumn2u
Copy link
Owner Author

sumn2u commented Jun 10, 2024

@sumn2u Since it wasn't supper clear, is there an existing configuration file where this value should be loaded from, or is creating a configuration file also required? And if so, where should It be located, and do you have any preferences for the file format

@Mews We currently don't have the configuration file. This task will involve creating a configuration file called config.py where we will define MASK_BACKGROUND_COLOR and set its value. The file will be added to the server folder and used in app.py.

An example of configuration file along its usage is shown here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants