Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monaco-language-apidom): completion filtering #4269

Closed

Conversation

kowalczyk-krzysztof
Copy link

Refs #4216

The implementation filters out completion items which have labels that don't contain the input as a subsequence.

@frantuma
Copy link
Member

@kowalczyk-krzysztof this can be a solution, but I would rather address it in underlying completion provider (in apidom-ls

This is possibly related to swagger-api/apidom#2734, even if the change there shouldn't theoretically cause the reported behavior.

As a tech note possibly this function can be related

I can have a look tomorrow/thursday

@char0n
Copy link
Member

char0n commented Jul 14, 2023

swagger-api/apidom#2734 shouldn't cause this as it's been released in https://github.com/swagger-api/swagger-editor/releases/tag/v5.0.0-alpha.58

Here is the alpa.41 manifesting the same behavior: https://swagger-editor-dsl.surge.sh/

@char0n
Copy link
Member

char0n commented Jul 14, 2023

I agree with @frantuma, we should address this in ApiDOM, as it's single source of truth for the completion items. Fixing it here would only solve issue with SwaggerEditor.

@kowalczyk-krzysztof
Copy link
Author

kowalczyk-krzysztof commented Jul 14, 2023

@char0n @frantuma Thanks for your comments! I will look into fixing this issue in ApiDOM.

I will close this PR.

@kowalczyk-krzysztof kowalczyk-krzysztof removed the request for review from char0n July 14, 2023 15:12
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the fix-completition-item-provider-subsequence branch July 14, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants