Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on events when in goal modal? #2006

Open
byorgey opened this issue Jul 1, 2024 · 2 comments
Open

Pass on events when in goal modal? #2006

byorgey opened this issue Jul 1, 2024 · 2 comments
Labels
C-Low Hanging Fruit Ideal issue for new contributors. S-Moderate The fix or feature would substantially improve user experience. T-Tutorial Involves the tutorial experience for new players. T-UI Involves the user interface. Z-User Experience This issue seeks to make the game more enjoyable to play.

Comments

@byorgey
Copy link
Member

byorgey commented Jul 1, 2024

When the goal modal is open (i.e. when first loading a scenario), it is possible to click on other panels (e.g. REPL) to focus them, but keystrokes do not reach them. So e.g. it is impossible to type in the REPL while the goal modal is still open. This is especially noticeable during the tutorials, some of which explicitly tell you to click on the inventory panel, or do something in the REPL, and many of which explain some example code you can use. But in order to type this example code you must just memorize the code, close the goal panel, and then type (and then also remember that you can type Ctrl+G to bring up the panel again briefly, memorize further, close, keep typing...)

Sometimes, when there are multiple goals, keypress events actually do something in the goals modal (i.e. move around in the list of goals). I am not quite sure of the right thing to do in that case. But at least in the case of only a single goal, I think we should send events to the handler for whatever panel has focus.

@byorgey byorgey added Z-User Experience This issue seeks to make the game more enjoyable to play. C-Low Hanging Fruit Ideal issue for new contributors. S-Moderate The fix or feature would substantially improve user experience. T-UI Involves the user interface. T-Tutorial Involves the tutorial experience for new players. labels Jul 1, 2024
@xsebek
Copy link
Member

xsebek commented Jul 31, 2024

Could we give the goal modal focus? Then it would be clear if the event was meant for it.

@byorgey
Copy link
Member Author

byorgey commented Aug 2, 2024

Oh, you mean add the goal modal to the focus ring, so events get sent to whichever panel (or modal) has focus? Yes, that makes sense!

And this doesn't have to be specific to the goal modal --- we should just add any modal window to the focus ring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Low Hanging Fruit Ideal issue for new contributors. S-Moderate The fix or feature would substantially improve user experience. T-Tutorial Involves the tutorial experience for new players. T-UI Involves the user interface. Z-User Experience This issue seeks to make the game more enjoyable to play.
Projects
None yet
Development

No branches or pull requests

2 participants