Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Retryable in OpsManagerFacade probably does not work #268

Open
1 task
ampersand8 opened this issue Jun 12, 2019 · 0 comments
Open
1 task

Retryable in OpsManagerFacade probably does not work #268

ampersand8 opened this issue Jun 12, 2019 · 0 comments

Comments

@ampersand8
Copy link
Contributor

Problem

OpsManagerFacade is using Springs @Retryable for one of its methods. In a recent change, the constructor of the MongoDbEnterpriseServiceProvider was changed to instantiate the OpsManagerFacade by calling new OpsManagerFacade() rather than using Springs autowiring. With that the @Retryable annotation is no longer recognized, and the method is therefore not retried anymore in case of failures. Making things worse, there's no test verifying the retries for this method.

Requirements

  • Verification of retries for the method

Proposal

  • Add tests for OpsManagerFacade, specifically testing the @Retryable. Ideally done with WireMock.
  • Fix instantiation of the OpsManagerFacade in MongoDbEnterpriseServiceProvider.

Alternative

  • Drop using @Retryable and implement another mechanism to retry the failed action.

Links

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant