Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optically thick sphere #5994

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ffoucart
Copy link
Contributor

Proposed changes

Example of a full MC evolution, not coupled to the fluid

Upgrade instructions

None

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

@ffoucart
Copy link
Contributor Author

Provided as an example of code usage so far (though the test itself is useful as well).
Depends on 5902 and 5907.

@ffoucart ffoucart added the dependent Needs a different PR to be merged in first label May 15, 2024
@ffoucart ffoucart force-pushed the OpticallyThickSphere branch 2 times, most recently from 72c504a to 8aca66f Compare June 5, 2024 15:06
@ffoucart ffoucart removed the dependent Needs a different PR to be merged in first label Jul 3, 2024
@ffoucart
Copy link
Contributor Author

ffoucart commented Jul 3, 2024

Rebased against the latest MC changes.

@ffoucart
Copy link
Contributor Author

@SamanthaRath This is the current test set up for optically thick sphere and boosted sphere. I just rebased on develop and recompiled; seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant