Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inspiral.yaml #6291

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AlexCarpenter46
Copy link
Contributor

@AlexCarpenter46 AlexCarpenter46 commented Sep 16, 2024

Proposed changes

Updates the Inspiral.yaml to be what worked well in @geoffrey4444's BBH runs for the paper. This also starts to set up the volume data needed for the transition to ringdown.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Do we want to cleanly terminate the run at a certain separation?

@knelli2 knelli2 added the cli/pybindings Command line interface & Python bindings label Sep 16, 2024
@knelli2 knelli2 added this to the BBH Pipeline Automation milestone Sep 16, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small requset for clarification :)

Comment on lines 350 to 351
- Lapse
- ConstraintEnergy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised we write out the constraint energy and lapse. I think these could be computed from the 3 evolved variables. It would be good to have a comment why they are observed instead of computed when needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we don't think we need to output those for the transition to ringdown script to work, they were originally there to see where the constraints were blowing up or getting large. I can take that out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the pipeline and transition to ringdown, yeah we probably don't need these.

support/Pipelines/Bbh/Inspiral.yaml Outdated Show resolved Hide resolved
Comment on lines 350 to 351
- Lapse
- ConstraintEnergy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the pipeline and transition to ringdown, yeah we probably don't need these.

@AlexCarpenter46
Copy link
Contributor Author

Squashed those changes in @nilsdeppe and @knelli2 :)

@knelli2 knelli2 added auto-merge GitHub's auto-merge has been enabled for this PR. and removed auto-merge GitHub's auto-merge has been enabled for this PR. labels Sep 27, 2024
@knelli2
Copy link
Contributor

knelli2 commented Sep 28, 2024

@AlexCarpenter46 Could you rebase on latest develop? There's a conflict now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants