Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge similar functionality into generics, remove redundancy #35

Open
ondrej33 opened this issue May 2, 2024 · 0 comments
Open

Merge similar functionality into generics, remove redundancy #35

ondrej33 opened this issue May 2, 2024 · 0 comments
Assignees

Comments

@ondrej33
Copy link
Member

ondrej33 commented May 2, 2024

On the Rust side, there are currently a few parts that might potentially be redundant. As it is all still in the early development phase, this might change (so I am not doing larger refactoring yet). Once we move a bit, however, we should be aware that the following things could be merged together or (with some changes) removed:

  • In the properties module, DynProperty and StatProperty implement similar API, we can probably move it into a separate Property trait.
  • Manager classes currently implement their own serde (de)serialization - this could probably be avoided using some utilities and serde tags. It might also become obsolete completely, as it seems the (de)serialization will be done through suitable intermediate structs (see data_structs module).
  • Some of the low-level structs in data_structs module might become redundant (mainly different kinds of properties, and some enums), as their main goal is to allow for simple (de)serialization, and the same could probably be achieved through the use serde tags. This is not the case for the "top-level" structures.
@ondrej33 ondrej33 self-assigned this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant