Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Clean up creation of objects #80

Closed
Tracked by #71
xtrojak opened this issue Jun 2, 2023 · 3 comments
Closed
Tracked by #71

Testing: Clean up creation of objects #80

xtrojak opened this issue Jun 2, 2023 · 3 comments

Comments

@xtrojak
Copy link
Collaborator

xtrojak commented Jun 2, 2023

A lot of testing objects are created in the tests. These are probably often repeated and redundant. This should get cleaned up by for example putting them into a single location and importing them in the tests.

@xtrojak
Copy link
Collaborator Author

xtrojak commented Dec 3, 2023

This can also include models - these are sometimes as strings, sometimes as files - unify to files.

@xtrojak
Copy link
Collaborator Author

xtrojak commented Dec 3, 2023

For the objects that are created by parsing we can basically have a separate file, where individual parsers are also available.

model_parser = Parser("model")
complex_parser = Parser("rate_complex")

complex1 = complex_parser.parse("KaiC(S{a}).T{u}::cyt").data.children[0]
...

Just pay attention to namespaces then.

@xtrojak
Copy link
Collaborator Author

xtrojak commented Dec 19, 2023

This was partially targeted in #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant