You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recently accepted PR (#16053) which was primarily about removing superfluous progn's seems to have inadvertently made broad changes to the spacemacs-editing layer's packages.el file.
This link will take you to the relevant diff (although it takes a while to load). Based on the changed copyright date, I think that a very old version of that file accidentally snuck in, and since the diff is so big it was probably just overlooked.
One of the consequences was to break the binding of SPC j j to evil-avy-goto-char-timer which was fixed in #16065, but the damage is much bigger than that. For example, a whole bunch of packages (e.g., password-generator, evil-easymotion, and many more) were removed from that layer. Indeed, I noticed the issue because g s no longer brought up evil-easymotion, and I went digging to figure out where it went.
It looks like some of the other accidental changes have already been addressed, e.g., 4d86d5c fixes damage to the undo-tree config, but there's still a lot of other unintended edits that need to be adddressed.
4ec0b8b's edits to the spacemacs-editing layer's packages.el file should probably be wholesale rolled back and then, to bring the file into line with what #16053 was trying to do, it should have its superfluous progn's removed. Perhaps @equwal, the author of #16053, is in a good position to remedy this?
The text was updated successfully, but these errors were encountered:
A recently accepted PR (#16053) which was primarily about removing superfluous
progn
's seems to have inadvertently made broad changes to the spacemacs-editing layer'spackages.el
file.This link will take you to the relevant diff (although it takes a while to load). Based on the changed copyright date, I think that a very old version of that file accidentally snuck in, and since the diff is so big it was probably just overlooked.
One of the consequences was to break the binding of
SPC j j
toevil-avy-goto-char-timer
which was fixed in #16065, but the damage is much bigger than that. For example, a whole bunch of packages (e.g.,password-generator
,evil-easymotion
, and many more) were removed from that layer. Indeed, I noticed the issue becauseg s
no longer brought upevil-easymotion
, and I went digging to figure out where it went.It looks like some of the other accidental changes have already been addressed, e.g., 4d86d5c fixes damage to the
undo-tree
config, but there's still a lot of other unintended edits that need to be adddressed.4ec0b8b's edits to the spacemacs-editing layer's
packages.el
file should probably be wholesale rolled back and then, to bring the file into line with what #16053 was trying to do, it should have its superfluousprogn
's removed. Perhaps @equwal, the author of #16053, is in a good position to remedy this?The text was updated successfully, but these errors were encountered: