-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated versioneer. Closes #27 #28
Conversation
a11e367
to
e0a201f
Compare
be6e707
to
0db5318
Compare
0db5318
to
2a66b0b
Compare
@@ -23,6 +25,3 @@ def _test_sphinx_build(app, status, warning): | |||
|
|||
assert not status.read() | |||
assert not warning.read() | |||
|
|||
def test_sphinx_build(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this was required or if I am missing something. Seems to work now anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably was required because pytest somehow didn't work with the actual test function (maybe the old test library didn't use a proper pytest fixture?). If it works now without this then we don't need it.
Thanks for this. I updated the branch protection rules for the new builds. I'm assuming this doesn't need a release, since it doesn't affect anything until Python 3.11. |
I think I did the right thing...
Had to drop 2.7-support as the new versioneer doesn't support it.
Also added all (?) 3.x versions for testing.
Ended up replacing sphinx-testing with sphinx.testing, so now the test suite should be fine for 3.11 as well...