Improve outside click support #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to use `pointerdown`, but some older devices with iOS 12 didn't have support for that. Instead we used `mousedown`. But now it turns out that some devices only properly use `pointerdown` and not the `mousedown` event. Instead, we will listen to both, but make sure to only handle the event once.
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/GR78VjBYEjgzP43xUAzcFifZY4YH headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/EADEzs2HNRciwZX5eEMSMBvhaJ8D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use
pointerdown, but some older devices with iOS 12 didn'thave support for that. Instead we used
mousedown. But now it turns outthat some devices only properly use
pointerdownand not themousedownevent.Instead, we will listen to both, but make sure to only handle the event
once.
Fixes: #1173