Remove focus() from Listbox Option
#1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/ADPyrZ2q23hAALAzDDiehNohnx7F headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/4r5TYv1NpUmpCUXew4R9NZHwn3UX |
We keep the actual container focused, so we don't require the invidiual option to be focused as well. We do want to scroll it into view but that's part of another piece of code. Also cleaned up some manual `document.querySelector` calls now that we keep track of a `ref`.
RobinMalfait
force-pushed
the
fix-listbox-transitions
branch
from
7507ff9
to
5b5fbb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep the actual container focused, so we don't require the invidiual
option to be focused as well. We do want to scroll it into view but
that's part of another piece of code.
This should fix an issue where transitions are cut-off because we want the item
to be focused immediately. One fix is to use our
focusElementhelper whichessentially adds the
{ preventScroll: true }options. This will be needed ifwe want to switch to the roving tabindex strategy, but not right now.
Also cleaned up some manual
document.querySelectorcalls now that wekeep track of a
ref.This should fix #587 because it gets rid of the weird
focus()call and this now results in almost exactly the same code as theMenucomponent.