Improve some internal code #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we introduced the `forwardRef` for all components, we also made sure that internal `ref`s were used to keep track of the actual DOM node. This code prefers the `internalXXRef` refs in favor of the `document.getElementById` calls. This is way more React-ish, and also fixes a few issues: - Potential performance improvements (no need to re-query the DOM, since we already have a reference to the DOM node). Note: this is a *guess*, I didn't measure this. - It could be that the element is rendered in another `document`, the correct would involve something like `someDOMNode.ownerDocument.getElementById(...)` but that should not be necessary anymore now.
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/85WwNe8WmqgUtLCwWz84FXcyppaC headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/3xwYRb9qr1v5WbtxQff9ofNxwHuv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will cleanup and refactor some internal code.
document.getElementByIdcalls