Fix incorrect transitionend/transitioncancel events for the Transition component #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Due to bubbling, the `Transition` component also "finished" when you had children that uses `transition-colors` for example. This commit ensures that we only care about transition events related to the actual DOM node that we defined the transitions on...
RobinMalfait
force-pushed
the
fix/issue-1517
branch
from
f0b2183
to
9af2303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bubbling, the
Transitioncomponent also "finished" when you hadchildren that uses
transition-colorsfor example.This commit ensures that we only care about transition events related to
the actual DOM node that we defined the transitions on...
Fixes: #1517