Ensure Transition component completes if nothing is transitioning
#2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Also added a `group` function, this allows us to spawn a _sub_ disposables group that can be disposed on its own, but will also be disposed the moment the "parent" is disposed.
RobinMalfait
force-pushed
the
fix/issue-2114
branch
from
a47f601
to
2520e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
Transitioncomponent causes sub-components (like aDialog) to get "stuck" because it nevers finishes transitioning.This can happen if there is nothing to transition at all (e.g.:
display: block;->display: none;).If this happens then the
transitionendevent is never fired and therefore it's waiting for nothing and gets stuck.Fixes: #2114