Omit nullable prop from Combobox component
#3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I kinda feel like we should have a test for this — thoughts? I know it's a minor thing but seems reasonable to me. |
This should help improve migrating to v2 because otherwise the `nullable` prop (that doesn't do anything) could end up on the `Fragment` and cause errors.
RobinMalfait
force-pushed
the
fix/drop-combobox-nullable-prop
branch
from
c0157b0
to
1e6c815
Compare
thecrypticace
approved these changes
Apr 15, 2024
RobinMalfait
force-pushed
the
fix/drop-combobox-nullable-prop
branch
from
1e6c815
to
74cea0e
Compare
RobinMalfait
force-pushed
the
fix/drop-combobox-nullable-prop
branch
from
74cea0e
to
a710ba0
Compare
thecrypticace
approved these changes
Apr 15, 2024
This was referenced May 28, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deprecated the
nullableprop because this is now the default behavior. However, we didn't delete the prop from the incomingprops. This means that thenullableprop will end up in the underlying DOM node, or worse theFragment(default tag) and error.This PR fixes that by eating the
nullableprop so that it never ends up on the underlying DOM node orFragment.