Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Redux 2.x #563

Open
DerekCaelin opened this issue Feb 27, 2024 · 2 comments
Open

Update to Redux 2.x #563

DerekCaelin opened this issue Feb 27, 2024 · 2 comments

Comments

@DerekCaelin
Copy link
Collaborator

DerekCaelin commented Feb 27, 2024

Update Shared Client and Web Client to support Redux 2.x. Currently, these fail TypeScript validation:

techmatters/terraso-client-shared#286
techmatters/terraso-web-client#1528

From Garo in techmatters/terraso-client-shared#239:

all the redux packages just got a major version bump with breaking changes. we should validate that upgrading them doesn't introduce any bugs to either the web or mobile client, and upgrade the versions in all 3 repos at the same time. the web client especially should get extra validation since we don't have TS to catch any bugs at build time

@DerekCaelin DerekCaelin added this to the 1000L 2024-04 milestone Feb 27, 2024
@paulschreiber paulschreiber changed the title Redux review Update to Redux 2.x Feb 27, 2024
@DerekCaelin
Copy link
Collaborator Author

In upgrade, they are hiding some implementation details we are using to customize our implementation. Dependent on Garo's PR to Redux. reduxjs/redux-toolkit#4289

@DerekCaelin DerekCaelin removed the 1000L label Apr 17, 2024
@DerekCaelin DerekCaelin removed this from the 1000L 2024-05 milestone May 16, 2024
@josebui
Copy link

josebui commented Aug 8, 2024

This still needs more work, not sure how much of the https://github.com/techmatters/terraso-client-shared/blob/main/src/store/store.ts needs to be changed since some types seems to be defined differently the last import I was not able to get is ToolkitStore and it also seems that Middleware has changed.

@josebui josebui removed their assignment Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked / Waiting
Development

No branches or pull requests

2 participants