Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use :check-paths in check task if specified #2804

Open
vemv opened this issue Oct 19, 2022 · 4 comments
Open

Use :check-paths in check task if specified #2804

vemv opened this issue Oct 19, 2022 · 4 comments

Comments

@vemv
Copy link
Contributor

vemv commented Oct 19, 2022

Hi there!

Becase check.clj checks only :source-paths, it is not intuitive to make lein check also check test/ namespaces.

(One might have guessed that with-profile +test would work - but nope)

A simple fix would seem to also honor :test-paths if the test profile is active.

(Note that always enabling it might fail, since the :test profile can add :dependencies otherwise absent)

There's the workaround of adding :profiles {:test {:source-paths ["test"]}} but if feels pretty wrong.

Cheers - V

@technomancy
Copy link
Owner

Good point.

What if it defaulted to using :source-paths only if :check-paths was absent? Then it could be easily overridden.

@vemv
Copy link
Contributor Author

vemv commented Oct 21, 2022

This also SGTM and probably it's easier to convey/maintain :)

@technomancy
Copy link
Owner

Would you like to take a shot at this?

@vemv
Copy link
Contributor Author

vemv commented Oct 21, 2022

Not atm - sorry!

@technomancy technomancy changed the title Cannot check :test-paths with lein check Use :check-paths in check task if specified Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants