invalid type signature for arcgisToGeoJSON

[tomwayson]

Seems like this line

export function arcgisToGeoJSON(arcgis: ArcGIS.Geometry, idAttribute?: string): GeoJSON.GeometryObject;

Should be:

export function arcgisToGeoJSON(arcgis: ArcGIS.Geometry | ArcGIS.Feature | ArcGIS.FeatureSet, idAttribute?: string): GeoJSON.GeometryObject;

Based on the description:

Param	Type	Description
JSON	object	The input ArcGIS geometry, feature or feature collection.

[jgravois]

greetings old friend. 👋

a PR (to DefinitelyTyped) would most certainly be welcome.

[tomwayson]

greetings indeed.

I did start on that, but the above change didn't solve the problem in my environment, likely due to mismatches between the "arcgis-rest-api" types and the corresponding types from @arcgis/core and I just ended up sprinkling as any through my code.

This made me wonder if the types for this library should be using the actual types from @arcgis/core, but that feels like a bigger issue.

[jgravois]

i don't have any firm opinions about better Typescript support. this library is pretty mature/stable at this point so i'm not opposed to (someone else) tackling a full-blown revamp. i wouldn't expect it to be yeoman's work.

i'd also be fine with moving the typings here if it'd make maintenance easier. ❤️