Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LayerTree does not need to store LayerTreeNode in the state #2015

Open
simonseyock opened this issue Feb 22, 2021 · 0 comments
Open

LayerTree does not need to store LayerTreeNode in the state #2015

simonseyock opened this issue Feb 22, 2021 · 0 comments
Labels
enhancement performance refactoring

Comments

@simonseyock
Copy link
Member

The LayerTreeNode does not need to get stored in in the state. In fact it is discouraged to store react elements in the store. This was causing typing issues. The generation of the nodes can be wrapped in a memoize function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement performance refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnlkoch @simonseyock