Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tell the user when we can't remove the image if it's in use #406

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

damacus
Copy link
Contributor

@damacus damacus commented Nov 15, 2023

Description

Please describe what this change achieves

Issues Resolved

List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant

Type of Change

Our release process assumes you are using Conventional Commit messages.

The most important prefixes you should have in mind are:

  • _fix_: which represents bug fixes, and correlates to a SemVer patch.
  • _feat_: which represents a new feature, and correlates to a SemVer minor.
  • _feat!_:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.

If you have not included a conventional commit message this can be fixed on merge.

Check List

@damacus
Copy link
Contributor Author

damacus commented Nov 25, 2023

waiting for #410

xorima
xorima previously approved these changes Nov 26, 2023
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Co-authored-by: Edward Smith <edward@ersmith.me>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
@damacus damacus changed the title Fix: Tell the user when we can't remove the image if it's in use feat: Tell the user when we can't remove the image if it's in use Nov 27, 2023
@damacus damacus merged commit bcb7c2b into main Nov 27, 2023
50 of 65 checks passed
@damacus damacus deleted the image-in-use-fix branch November 27, 2023 10:53
@damacus
Copy link
Contributor Author

damacus commented Nov 27, 2023

@ersmith thanks very much for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants