Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Umbraco v. 13 #2

Open
martinbrud opened this issue Sep 9, 2024 · 0 comments
Open

Does not work on Umbraco v. 13 #2

martinbrud opened this issue Sep 9, 2024 · 0 comments

Comments

@martinbrud
Copy link

martinbrud commented Sep 9, 2024

I have created this issue on https://our.umbraco.com/forum/using-umbraco-and-getting-started//114651-package-tinifier-does-not-work-on-umbraco-v-13, but I have had no response, so I think it makes more sense to post here 😊

I have installed it on Umbraco Cloud (but same issue is also on non Umbraco Cloud installations):

<PackageReference Include="Umbraco.Cloud.Cms" Version="13.0.0" />
<PackageReference Include="Cogworks.Tinifier" Version="1.0.0" />

First of all: After install I can't see Tinifier as a "Sections" option in settings for a user group. If found that folder App_Plugins\Cogworks.Tinifier was not present so I copied files from https://github.com/thecogworks/Cogworks.Tinifier to it. Then I could see Tinifier as a "Sections" option in settings for a user group and added it.

But 2 problems are still there:

Problem 1) But when clicking "Tinify everything!" in the dashboard this error occurs multiple times in log file (once per image in the bakend I guess):

    Microsoft.Data.Sqlite.SqliteException (0x80004005): SQLite Error 1: 'no such column: day'.\r\n   at Microsoft.Data.Sqlite.SqliteException.ThrowExceptionForRC(Int32 rc, sqlite3 db)\r\n   at Microsoft.Data.Sqlite.SqliteCommand.PrepareAndEnumerateStatements()+MoveNext()\r\n   at Microsoft.Data.Sqlite.SqliteCommand.GetStatements()+MoveNext()\r\n   at Microsoft.Data.Sqlite.SqliteDataReader.NextResult()\r\n   at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior behavior)\r\n   at StackExchange.Profiling.Data.ProfiledDbCommand.ExecuteDbDataReader(CommandBehavior behavior) in C:\\projects\\dotnet\\src\\MiniProfiler.Shared\\Data\\ProfiledDbCommand.cs:line 201\r\n   at Umbraco.Cms.Infrastructure.Persistence.FaultHandling.RetryPolicy.ExecuteAction[TResult](Func`1 func)\r\n   at NPoco.Database.ExecuteReaderHelper(DbCommand cmd)\r\n   at NPoco.Database.ExecuteDataReader(DbCommand cmd, Boolean sync)\r\n   at NPoco.AsyncHelper.RunSync[T](Task`1 task)\r\n   at NPoco.Database.QueryImp[T](T instance, Expression`1 listExpression, Func`2 idFunc, Sql Sql, PocoData pocoData)+MoveNext()\r\n   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)\r\n   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)\r\n   at Cogworks.Tinifier.Repository.History.HistoryRepository.GetAll()\r\n   at Cogworks.Tinifier.Services.History.HistoryService.GetStatisticByDays()\r\n   at 
...

And when uploading new images no tinifying is made.

Problem 2) When opening an image in backend (i.e. https://localhost:44378/umbraco/#/media/media/edit/1250) and clicking Actions > Stats the dialog looks like:

image

So it seems that 1) tinifying does not work/does not happen and 2) some files are missing in App_Plugins\Cogworks.Tinifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant