-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend with an empty var. #4454
Comments
This would be much better suited as a pull request. |
@creadivteam I'm no familiar with that part of code but what you posted as solution is what the code looks like right now. - if (!this.settings.map) { // Load extra character map translator
+ if (this.settings.map) { // Load extra character map translator
$.extend(this.chars, this.settings.map);
} Can you propose a PR? |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version information
Description
You can't extend default slugify char maps because you try to merge with an empty var.
Solution
Fix the condition before merge default map with the one you provide.
The text was updated successfully, but these errors were encountered: