Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2 #147

Open
snapshotpl opened this issue Oct 29, 2020 · 15 comments
Open

Release v2 #147

snapshotpl opened this issue Oct 29, 2020 · 15 comments

Comments

@snapshotpl
Copy link
Contributor

I have a question about ETA for release v2: When :)

Currently we have master branch which is reserved for v2, but v1 need updates to support php8. For me release v2 is ok, but to make everything smooth and ease to upgrade, create v1 branch and add support for php8 will be nice addon.

@snapshotpl
Copy link
Contributor Author

@rosstuck any news here?

@rosstuck
Copy link
Member

rosstuck commented Dec 8, 2020

I started a new job last month so time is nil. That said, I created a new 1.x branch that was forked over the last tagged release and updated a few tests to get things green on at least 7.4, waiting on builds for 8.0 but I doubt that will happen considering how old the version of PHPUnit is. If you know of anything that keeps the older releases from working on PHP 8, I'm happy to take a PR on the new 1.x branch and tag a release there.

Honestly, at this point, the blocker remains putting time into the Bundle. I have a local branch where I'm getting more and more of the tests passing without cutting the current feature. If you're interested in picking that up, happy to push and collaborate.

Alternately, I'm getting more and more tired of the upkeep required to stay in the Symfony ecosystem when I haven't been involved in it for several years, so maybe I just need to drop it but considering the bundle has about half the same number of installs as the main package, it seems like there's a large number of users.

@snapshotpl
Copy link
Contributor Author

I think we can just drop some unsupported versions for v1 and add PHP 8.0. It isn't BC break.

For v2 I suggest to release this version and then prepare and release bundle/module/plugin/extension where needed.

@rosstuck
Copy link
Member

rosstuck commented Dec 8, 2020

A v1.1 release that targets PHP 7.x and PHP 8.x compatibility is fine with me, as a transition step to 2.0 which targets 7.4 and 8.0 exclusively. If you'd like to put in the effort on getting a 1.x branch in order for that, I'm happy to merge and tag. Literally the least I can do 😁

@snapshotpl
Copy link
Contributor Author

@rosstuck thanks for release 1.1! What's next to finish 2.0 work?

@rosstuck
Copy link
Member

rosstuck commented Mar 7, 2021

Pretty much unchanged, still the bundle and docs. My aforementioned PR has the same features working but some of the routing stuff still needs to be worked out and there's a couple small BC breaks. Every so often I'll sit down and get a couple more bundle tests passing but I fully confess it's not a big life priority right now.

Current Tactician keeps working (thanks to your contributions and others!) and the only real interesting feature in T2 is the PHPStan integration which I think is neat but honestly guess nobody else really cares about much so there's not a lot of push for it, I reckon :)

@floriankraemer
Copy link

Any news? Can we expect a 2.0.0 tag at some point? I don't mind helping to finish the release, just not the bundle because I'm not using Symfony.

@gravataLonga
Copy link

It's a shame a good library like this one, don't receive any update. Really to love see some active development on this library.

@snapshotpl
Copy link
Contributor Author

@rosstuck I can take under wing tactician if I have permissions

@simPod
Copy link

simPod commented Jul 11, 2023

I think @frankdejonge had some activity here as last maintainer.

@gravataLonga
Copy link

I can help too in anyway, if needed.

@frankdejonge
Copy link
Member

Hi all, I've been preoccupied. If there are any issues that you'd like to see addressed, list them here and I'll get on that.

@gravataLonga
Copy link

For me, probably the most important are:

  • take advantage of some new feature of PHP 8.0/8.1/8.2, probably there aren't that many (need more research)
  • using PHPStan probably?
  • As client perspective, know that is still active and health state.

@simPod
Copy link

simPod commented Jul 11, 2023

I think we can send PRs. Seems like Frank may be happy to do a review and maintenance stuff.

@robertobermejo
Copy link

Hello, is there any planned release date for version 2? I am a user of this project and I would be willing to help both in this project and in the symfony bundle for the necessary versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants