Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument order in factor unintuitive #641

Closed
mgkurtz opened this issue Apr 7, 2022 · 1 comment · Fixed by #1094
Closed

Argument order in factor unintuitive #641

mgkurtz opened this issue Apr 7, 2022 · 1 comment · Fixed by #1094

Comments

@mgkurtz
Copy link
Contributor

mgkurtz commented Apr 7, 2022

Factorizing rationals is done via factor(QQ(3, 4), ZZ), but I would expect factor(ZZ, QQ(3, 4)) instead. The latter would be as in other Oscar functions, where we first give the ring and then elements. Point 4 in the argument order according to the Julia style guide also hints us, that the ring (which determines the output type) should come first.

The same applies to other factor methods.
This was referenced May 29, 2023
Merged
Merged
@lgoettgens
Copy link
Contributor

lgoettgens commented May 29, 2023 •
edited
Loading

This will be resolved by #1094, Nemocas/AbstractAlgebra.jl#1374, Nemocas/Nemo.jl#1486 and oscar-system/Oscar.jl#2433.

@mgkurtz mgkurtz closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change argument order in factor and roots lgoettgens/Hecke.jl
2 participants
@mgkurtz @lgoettgens