Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote isn't reversible #50

Open
JulianBirch opened this issue Aug 15, 2013 · 3 comments
Open

Blockquote isn't reversible #50

JulianBirch opened this issue Aug 15, 2013 · 3 comments

Comments

@JulianBirch
Copy link

If you hit the demo page, select two paragraphs and then hit quote twice, it sticks the two paragraphs together.

Not the world's biggest problem, I'll admit...

@tholman
Copy link
Owner

tholman commented Aug 18, 2013

This bug is really frustrating me... I'm struggling a bit to get solid (bug free) on/off states for block quotes. The rich text api is really very flakey... I'm starting to think resorting to manual dom parsing/editing will be the way to go, but then the text highlighting becomes a problem.

@JulianBirch
Copy link
Author

I feel bad about reporting it now. Sounds really messy. :( Sorry I can't really help.

@tholman
Copy link
Owner

tholman commented Aug 22, 2013

Anyone else, feel free to have a crack at this. It feels like the execcommand api is pretty inconcistent when it comes to indenting, and unindenting areas... so I expect the bug free solution will involve changing the "p" tags to blockquotes, and back again on press... but will also need to re-highlight the same text area after those elements are replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants