Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to demos no longer work #195

Open
ryanshripat opened this issue Sep 29, 2017 · 3 comments
Open

Links to demos no longer work #195

ryanshripat opened this issue Sep 29, 2017 · 3 comments

Comments

@ryanshripat
Copy link

Links such as https://thomasjbradley.github.io/signature-pad/examples/accept-signature.html (linked from readme) return a 404 ("There isn't a GitHub Pages site here."). If you tell me where I can link to instead, I can update the documentation. Otherwise, I can attempt to provide a different URL by hosting the demos elsewhere (perhaps on github.io).

@mockdeep
Copy link
Collaborator

Hey @ryanshripat I could be wrong, but it looks like things should probably work if we change the urls to map to https://thread-pond.github.io/signature-pad/ instead. If you want to PR it, I'd be happy to merge it!

This was referenced Sep 29, 2017
@ryanshripat
Copy link
Author

I'd love to submit a PR, @mockdeep but both that link and https://thread-pond.github.io/ give the "There isn't a GitHub Pages site here" error. I suspect that the repo owner will be able to actually create a Pages site at that URL. In the meantime I can read up on the following: https://help.github.com/articles/user-organization-and-project-pages/

@mockdeep
Copy link
Collaborator

mockdeep commented Oct 2, 2017

@ryanshripat Oh, interesting. So it looks like the nested urls are available on the local GH pages, but for some reason the root url is not. This link works for me:

https://thread-pond.github.io/signature-pad/examples/accept-signature.html

It looks like the project pages will be available locally based on the repo, which the docs you share confirm in the Project Pages section, but it doesn't tell us how to get the root working. Just looking at a random other project, it looks like react-native has an index.html in the root of the project:

https://github.com/facebook/react-native/tree/gh-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants