IntelSiliconPkg: Code Quality Improvements #215
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits:
IntelSiliconPkg/IntelVTdDmarPei: Prevent invalid dereference
Prevent invalid DMAR ACPI table dereference if the table is not
found.
IntelSiliconPkg/SmmAccess: Fix potential integer overflow in loop comparison
SmmAccessDxe:
mSmmAccess.NumberRegions
is aUINTN
while the loop index variablecompared against it is a
UINT8
. This can lead to an overflow of theloop index for
mSmmAccess.NumberRegions
for values larger thanUINT8_MAX
. This change makesIndex
aUINTN
to match in width.PeiSmmAccessLib:
Fixes a similar
UINT8
loop index issue.