Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main for galactic release #25

Merged
merged 34 commits into from
Aug 31, 2022
Merged

merge main for galactic release #25

merged 34 commits into from
Aug 31, 2022

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Aug 31, 2022

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

takayuki5168 and others added 30 commits July 7, 2022 10:03
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: Akihito OHSATO <aohsato@gmail.com>
Signed-off-by: Akihito OHSATO <aohsato@gmail.com>
Signed-off-by: Akihito OHSATO <aohsato@gmail.com>
Signed-off-by: Akihito OHSATO <aohsato@gmail.com>
Signed-off-by: Akihito OHSATO <aohsato@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
fix(readme): refer to own repos file
* Added a documentation section to the sensor section reflecting our calibration design and a brief explanation of each calibration method

* Attempting to use underscores correctly in math mode. It works correctly on local but on github appears as an error

* Trying using the underscores outside math mode

* Another attempt

* mend

* mend

* mend

* mend

* mend

* mend

* mend

* Decided agains using "traditional underscores"
fix(deviation_evaluator): debugged map_launch in launch file
* Modified map based calibration for lidar to lidar

* Deleted unnecessary file

* fix cmakelist and launch for PR

* Update sensor/extrinsic_calibration_manager/src/extrinsic_calibration_manager_node.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_calibration_manager/include/extrinsic_calibration_manager/extrinsic_calibration_manager_node.hpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/src/extrinsic_map_based_calibrator.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/src/extrinsic_map_based_calibrator.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/src/extrinsic_map_based_calibrator.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/include/extrinsic_map_based_calibrator/extrinsic_map_based_calibrator.hpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/include/extrinsic_map_based_calibrator/extrinsic_map_based_calibrator.hpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/src/extrinsic_map_based_calibrator.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/include/extrinsic_map_based_calibrator/extrinsic_map_based_preprocessing.hpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/include/extrinsic_map_based_calibrator/extrinsic_map_based_preprocessing.hpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/include/extrinsic_map_based_calibrator/grid_search_matching.hpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sensor/extrinsic_map_based_calibrator/include/extrinsic_map_based_calibrator/grid_search_matching.hpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix for parallel processing optimization

* fix for build error

* Modified calibration param for xx1

* added threshold param to calibration manager

* using localization for sensor calibration with logging sim

* Modified judgement timing in extrinsic calib manager

* Chage default threshold for calibration manager

* Moved rviz calls to map based calib.launch

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yabuta yabuta merged commit cdfddc0 into main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants