Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pr template #4

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix pr template #4

merged 1 commit into from
Jul 7, 2022

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Jul 7, 2022

PR Type

  • Improvement

Related Links

Description

Fix pr template.
Delete private links and merge autoware.universe template.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@yabuta yabuta merged commit 2029d85 into tier4/universe Jul 7, 2022
kminoda pushed a commit that referenced this pull request Jul 7, 2022
* initial commit

* dyn cfg: change min param

* suppress backward time exception

* initialize tf using yaml setting

* fix order of initialization tf value

* if yaml is missing in the path, then tf parameters are set 0.0

* edit LICENSE

* fix: move shebang to top of source code

* revert LICENSE

* Feature cpp version (#4)

adding cpp version

* add dynparam clent to reflect yaml value to dynparam (#10)

* Port static tf broadcaster to ros2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Address review(Move .editorconfig to root)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Address review(Refactor update_param func)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Address review(Update readme)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Address review(Remove python)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Rename README.md to README_jp.md

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix README

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug in parameter update

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Hayato Mizushima <hayato.mizushima@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Hayato Mizushima <hayato.m126@gmail.com>
Co-authored-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
Co-authored-by: hiroaki-ishikawa-t4 <57431939+hiroaki-ishikawa-t4@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant