Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deviation_evaluator): debugged map_launch in launch file #6

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 7, 2022

PR Type

  • Bug Fix

Related Links

Description

deviation_evaluator in the previous failed to load map when rviz:=true.

I have verified that the lanelet2 map is properly visualized.

Review Procedure

Launch deviation_evaluator with rviz:=true map_path:=YOUR_MAP_DIR. Check the log and verify that lanelet2_map_visualization outputs Map is loaded.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda kminoda marked this pull request as draft July 7, 2022 06:31
@kminoda kminoda marked this pull request as ready for review July 8, 2022 02:56
@kminoda kminoda requested a review from YamatoAndo July 8, 2022 02:56
@kminoda
Copy link
Contributor Author

kminoda commented Jul 14, 2022

@YamatoAndo any comments on this?

@kminoda kminoda merged commit a958bb9 into tier4/universe Jul 15, 2022
@kminoda kminoda deleted the fix/map_launch_in_localization_tool branch November 30, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants