From 6de7f7ace5f127b2adfecf6784e070cd4724aa08 Mon Sep 17 00:00:00 2001
From: Shahzad <shahzad.muhammad@elastic.co>
Date: Tue, 10 Dec 2019 12:37:57 +0100
Subject: [PATCH] [Uptime] Feature/expandable row in details ping list (#51890)

* update columns

* update expand row in ping list
---
 .../__tests__/__snapshots__/monitor_list.test.tsx.snap      | 4 ++--
 .../__snapshots__/monitor_list_pagination.test.tsx.snap     | 4 ++--
 .../components/functional/monitor_list/monitor_list.tsx     | 2 +-
 .../__tests__/__snapshots__/ping_list.test.tsx.snap         | 6 ++++--
 .../public/components/functional/ping_list/ping_list.tsx    | 6 ++++--
 5 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap b/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap
index 3bf1d68590ec04a..0c6acb8d9f46e15 100644
--- a/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap
+++ b/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap
@@ -67,7 +67,7 @@ exports[`MonitorList component renders a no items message when no data is provid
             "name": "",
             "render": [Function],
             "sortable": true,
-            "width": "40px",
+            "width": "24px",
           },
         ]
       }
@@ -174,7 +174,7 @@ exports[`MonitorList component renders the monitor list 1`] = `
             "name": "",
             "render": [Function],
             "sortable": true,
-            "width": "40px",
+            "width": "24px",
           },
         ]
       }
diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap b/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap
index 91e7b2c07070c15..b7c8ddbc51b2765 100644
--- a/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap
+++ b/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap
@@ -67,7 +67,7 @@ exports[`MonitorList component renders a no items message when no data is provid
             "name": "",
             "render": [Function],
             "sortable": true,
-            "width": "40px",
+            "width": "24px",
           },
         ]
       }
@@ -174,7 +174,7 @@ exports[`MonitorList component renders the monitor list 1`] = `
             "name": "",
             "render": [Function],
             "sortable": true,
-            "width": "40px",
+            "width": "24px",
           },
         ]
       }
diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx b/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx
index 7b3b636d99b38d9..40a51f7c978e69d 100644
--- a/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx
+++ b/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx
@@ -208,7 +208,7 @@ export const MonitorListComponent = (props: Props) => {
               field: 'monitor_id',
               name: '',
               sortable: true,
-              width: '40px',
+              width: '24px',
               isExpander: true,
               render: (id: string) => {
                 return (
diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap b/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap
index 5f60ce38500c80b..a2e31a0f33d39f2 100644
--- a/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap
+++ b/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap
@@ -145,7 +145,7 @@ exports[`PingList component renders sorted list without errors 1`] = `
             "render": [Function],
           },
           Object {
-            "align": "right",
+            "align": "center",
             "field": "http.response.status_code",
             "name": "Response code",
             "render": [Function],
@@ -154,10 +154,12 @@ exports[`PingList component renders sorted list without errors 1`] = `
             "align": "right",
             "isExpander": true,
             "render": [Function],
-            "width": "40px",
+            "width": "24px",
           },
         ]
       }
+      hasActions={true}
+      isExpandable={true}
       itemId="id"
       itemIdToExpandedRowMap={Object {}}
       items={
diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx b/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx
index 0a97b596a7a71e3..b3c1de37c134067 100644
--- a/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx
+++ b/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx
@@ -190,7 +190,7 @@ export const PingListComponent = ({
   if (hasStatus) {
     columns.push({
       field: 'http.response.status_code',
-      align: 'right',
+      align: 'center',
       name: i18n.translate('xpack.uptime.pingList.responseCodeColumnLabel', {
         defaultMessage: 'Response code',
       }),
@@ -200,7 +200,7 @@ export const PingListComponent = ({
 
   columns.push({
     align: 'right',
-    width: '40px',
+    width: '24px',
     isExpander: true,
     render: (item: Ping) => (
       <EuiButtonIcon
@@ -300,6 +300,8 @@ export const PingListComponent = ({
         <EuiBasicTable
           loading={loading}
           columns={columns}
+          isExpandable={true}
+          hasActions={true}
           items={pings}
           itemId="id"
           itemIdToExpandedRowMap={itemIdToExpandedRowMap}