Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken base64 images #72

Closed
lambrechts opened this issue May 25, 2022 · 1 comment
Closed

Broken base64 images #72

lambrechts opened this issue May 25, 2022 · 1 comment

Comments

@lambrechts
Copy link
Contributor

First of all, thank you for developing this plugin. Made my life a lot easier.

I work with jupyter notebooks and mkdocs and there graphs will be outputted as base64 images. I discovered that Base64 images will be treated as a regular URL, and thus will be broken by the fix_image_src function. So I added a test for base64 images that checks if the url starts with data:image and ignores any base64 images found.

See PR #71

@timvink
Copy link
Owner

timvink commented Jun 1, 2022

@timvink timvink closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants