Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve evil.css via Github pages #13

Open
mx-moth opened this issue Jan 16, 2012 · 1 comment
Open

Serve evil.css via Github pages #13

mx-moth opened this issue Jan 16, 2012 · 1 comment

Comments

@mx-moth
Copy link

mx-moth commented Jan 16, 2012

Serving the css file using the 'raw' option serves the file with a mime-type of text/plain. This makes the css file fail to work in Firefox and other browsers. By making use of Github pages, the CSS file can be served with the correct mime-type, making the bookmarklet work in more browsers.

By simply making a gh-pages branch, Github pages will automatically be set up for you, with no more effort needed:

git clone https://github.com/tlrobinson/evil.css.git
git checkout -b gh-pages
git push origin gh-pages

Then, evil.css can be found at http://tlrobinson.github.com/evil.css/evil.css with the correct mine-type. Just keep master and gh-pages in sync, and Github will do the rest.

You can additionally make an index.html file to act as a landing page, where you can add the bookmarklet as an anchor for people to bookmark, but this step is completely optional.

@acusti
Copy link

acusti commented Feb 22, 2012

I can confirm that the demo bookmarklet code no longer works. There is an explanation of browser behaviour when a stylesheet link element points to a file whose type is not text/css in the section of the W3 HTML5 semantics working draft about the link element:

[The browser] would then check the actual types returned by the server. For those that are sent as text/css, it would apply the styles, but for those labeled as text/plain, or any other type, it would not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants