Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce contention in broadcast channel #5465

Open
Darksonn opened this issue Feb 17, 2023 · 0 comments
Open

Reduce contention in broadcast channel #5465

Darksonn opened this issue Feb 17, 2023 · 0 comments
Labels
A-tokio Area: The main tokio crate E-hard Call for participation: Experience needed to fix: Hard / a lot E-help-wanted Call for participation: Help is requested to fix this issue. M-sync Module: tokio/sync T-performance Topic: performance and benchmarks

Comments

@Darksonn
Copy link
Contributor

The PR #5464 reduced the contention in the watch channel by storing waiters in several buckets. We should investigate if this is also possible for the broadcast channel.
@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. A-tokio Area: The main tokio crate M-sync Module: tokio/sync E-hard Call for participation: Experience needed to fix: Hard / a lot T-performance Topic: performance and benchmarks labels Feb 17, 2023
@Darksonn Darksonn mentioned this issue Feb 17, 2023
Closed
vnetserg added a commit to vnetserg/tokio that referenced this issue Jan 14, 2024
@vnetserg
benches: add sync_broadcast benchmark
4f98a68 
Refs: tokio-rs#5465
vnetserg added a commit to vnetserg/tokio that referenced this issue Jan 14, 2024
@vnetserg
sync: reduce contention in broadcast channel
48d23bd 
Implement atomic linked list that allows pushing
waiters concurrently, which reduces contention.

Fixes: tokio-rs#5465
vnetserg added a commit to vnetserg/tokio that referenced this issue Jan 14, 2024
@vnetserg
sync: reduce contention in broadcast channel
a6856c2 
Implement atomic linked list that allows pushing
waiters concurrently, which reduces contention.

Fixes: tokio-rs#5465
vnetserg added a commit to vnetserg/tokio that referenced this issue Jan 14, 2024
@vnetserg
sync: reduce contention in broadcast channel
cd43fc9 
Implement atomic linked list that allows pushing
waiters concurrently, which reduces contention.

Fixes: tokio-rs#5465
This was referenced Jan 14, 2024
Closed
Merged
vnetserg added a commit to vnetserg/tokio that referenced this issue Jan 19, 2024
@vnetserg
benches: add sync_broadcast benchmark
19c8966 
Refs: tokio-rs#5465
vnetserg added a commit to vnetserg/tokio that referenced this issue Jan 27, 2024
@vnetserg
benches: add sync_broadcast benchmark
e20cc40 
Refs: tokio-rs#5465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate E-hard Call for participation: Experience needed to fix: Hard / a lot E-help-wanted Call for participation: Help is requested to fix this issue. M-sync Module: tokio/sync T-performance Topic: performance and benchmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Darksonn