Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that fuzz tests compile in CI #5601

Closed
Darksonn opened this issue Apr 5, 2023 · 4 comments · Fixed by #5682
Closed

Ensure that fuzz tests compile in CI #5601

Darksonn opened this issue Apr 5, 2023 · 4 comments · Fixed by #5682
Labels
A-tokio Area: The main tokio crate A-tokio-stream Area: The tokio-stream crate E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Apr 5, 2023

We don't run fuzz tests in our CI because they're executed elsewhere, but we should still make sure that they compile. To close this, submit a PR that updates our CI configuration to ensure that fuzz tests compile. The CI configuration can be found in the .github directory.

There are a few warnings in the fuzz tests currently, those should be fixed too.

See #5392 for context.

@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. E-easy Call for participation: Experience needed to fix: Easy / not much A-tokio Area: The main tokio crate A-tokio-stream Area: The tokio-stream crate labels Apr 5, 2023
@silvergasp
Copy link
Contributor

There is a github action for oss fuzz that can make this pretty simple. https://google.github.io/oss-fuzz/getting-started/continuous-integration/

@hootio
Copy link
Contributor

hootio commented May 3, 2023

Submitted #5670 for checking the /tokio/ subdir.
Was going to include /tokio-stream/ too but that had its own compilation warnings, which should be addressed in a separate PR.

@hootio
Copy link
Contributor

hootio commented May 10, 2023

Submitted #5675 to remove compilation warnings from /tokio-stream/. Next step is to add the compilation check step in CI and then this issue can be resolved.

@hootio
Copy link
Contributor

hootio commented May 10, 2023

Submitted #5682. Once merged, this issue can be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate A-tokio-stream Area: The tokio-stream crate E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants