Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the dependency of fbjs #134

Closed
tomchentw opened this issue Oct 15, 2015 · 1 comment
Closed

Drop the dependency of fbjs #134

tomchentw opened this issue Oct 15, 2015 · 1 comment

Comments

@tomchentw
Copy link
Owner

From 91d5790#commitcomment-13781930

@tomchentw fbjs is discouraged from being used outside of Facebook. If all you want is canUseDOM why not include a public lib like can-use-dom?
tomchentw referenced this issue Oct 15, 2015
@tomchentw
feat(src): move instance creation in componentWillMount
91d5790 
* saves extra render step compared with componentDidMount
* use ExecutionEnvironment to check canUseDOM
* depends on fbjs@^0.3.1
@tomchentw
Copy link
Owner Author

Released v4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomchentw