Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullwidth for the comming container block #89

Closed
SchneiderSam opened this issue Feb 20, 2019 · 6 comments
Closed

Fullwidth for the comming container block #89

SchneiderSam opened this issue Feb 20, 2019 · 6 comments

Comments

@SchneiderSam
Copy link

With Gutenberg 5.2 comes the long-awaited container block (WordPress/gutenberg#13964). It would be great if GeneratePress supports the fullwidth function. Similar to the pictures.

@SchneiderSam
Copy link
Author

An update: The Section Block appears at the next Gutenberg Version. It would be nice if Generatepress can join you here: WordPress/gutenberg#13964 (comment)

@SchneiderSam
Copy link
Author

So it's done and merged. But unfortunately only from 5.5 available. Here are some adjustments for theme authors: WordPress/gutenberg#13964 (comment)

@tomusborne
Copy link
Owner

Cool! Looks pretty good.

We actually have our own Section block ready to go, which integrates nicely with the way GP does things. We're just waiting on Gutenberg to fix a bug which removes all inner blocks when a container block no longer exists.

@SchneiderSam
Copy link
Author

That's interesting. So GP is working on own blocks. Well then I'm curious.

@SchneiderSam
Copy link
Author

Me again. With 5.5 this is now firmly in the core. But I think that GP has to build in a padding. Or?

Screenshot_2

@tomusborne
Copy link
Owner

GP should add its content padding to the core Group block now as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants