Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'pattern_library' defines default_app_config #159

Closed
nickmoreton opened this issue Dec 21, 2021 · 1 comment · Fixed by #160
Closed

'pattern_library' defines default_app_config #159

nickmoreton opened this issue Dec 21, 2021 · 1 comment · Fixed by #160
Labels
good first issue Good for newcomers

Comments

@nickmoreton
Copy link
Contributor

nickmoreton commented Dec 21, 2021 •
edited
Loading

Is your proposal related to a problem?

When used with Django 3.2, django-pattern-library is throwing deprecation warnings about the use of the defafult_app_config:

/usr/local/lib/python3.8/site-packages/django/apps/registry.py:91: RemovedInDjango41Warning: 'pattern_library' defines default_app_config = 'pattern_library.apps.PatternLibraryAppConfig'. Django now detects this configuration automatically. You can remove default_app_config.

Describe the solution you'd like

remove: default_app_config = 'pattern_library.apps.PatternLibraryAppConfig' when using Django >= 3.2

Describe alternatives you've considered

I will create a PR for this.

Additional context

https://docs.djangoproject.com/en/3.2/ref/applications/#for-application-authors
@nickmoreton nickmoreton added the good first issue Good for newcomers label Dec 21, 2021
@nickmoreton nickmoreton linked a pull request Dec 21, 2021 that will close this issue
Make default_app_config conditional #160
Merged
8 tasks
@nickmoreton nickmoreton mentioned this issue Dec 21, 2021
Merged
8 tasks
@thibaudcolas
Copy link
Member

Hey @nickmoreton, this has already been reported in #153 so I’ll close this issue. PR definitely welcome!

@nickmoreton nickmoreton removed a link to a pull request Dec 21, 2021
Make default_app_config conditional #160
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make default_app_config conditional torchbox/django-pattern-library
2 participants
@thibaudcolas @nickmoreton