Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config overhaul: remove default values from config file templates #856

Closed
josecelano opened this issue May 10, 2024 · 0 comments · Fixed by #858
Closed

Config overhaul: remove default values from config file templates #856

josecelano opened this issue May 10, 2024 · 0 comments · Fixed by #858
Assignees
Labels
Code Cleanup / Refactoring Tidying and Making Neat

Comments

@josecelano
Copy link
Member

Parent issue: #401

The new Figment configuration implementation allows you not to define config values when you want to use the default one. For example, you can run the tracker without providing any value:

TORRUST_TRACKER_CONFIG="" cargo run

And it will use default values. For the time being, all options have a default value.

Since we don't need to specify the default values, we should refactor the default config files to remove options with default values:

$ tree share/default/config
share/default/config
├── tracker_checker.json
├── tracker.container.mysql.toml
├── tracker.container.sqlite3.toml
├── tracker.development.sqlite3.toml
├── tracker.e2e.container.sqlite3.toml
└── tracker.udp.benchmarking.toml

That makes it easier to maintain them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant