-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Tpetra and Amesos2 tests with double off and float on #1142
Comments
In principle think we should be able to compile Trilinos with double off. This would prevent having hard-coded doubles used instead of the requested type. |
If people want to be able to shut off Scalar=double, then we could add that as a feature request. Note that enabling Scalar=complex currently requires Scalar=double to be enabled. |
I'm marking this as an "enhancement," since I have never met a Trilinos customer who wanted to shut off Scalar=double in their builds. That doesn't mean it shouldn't work, but it does help us set the priority for making such a thing work. |
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. |
This issue was closed due to inactivity for 395 days. |
@srajama1 This is for the double/float issue we discussed. We decided to have Amesos2 Umfpack provide a warning that type conversion would take place if built with float on and double off since Umfpack only supports double. So I had these settings:
Trilinos_ENABLE_FLOAT=ON
Tpetra_INST_DOUBLE=OFF
I found that Tpetra will not link with these settings if tests or examples are on - for example TpetraCore_BugTests.exe would not link. With only Amesos2 tests on, there are also link issues. I can build Tpetra and then Amesos2 under these settings with tests and examples off. So we may want to reconfigure things so Tpetra and Amesos2 would build tests/examples under these conditions.
The text was updated successfully, but these errors were encountered: