Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Tpetra and Amesos2 tests with double off and float on #1142

Closed
MicheldeMessieres opened this issue Mar 16, 2017 · 6 comments
Closed
Assignees
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. type: enhancement Issue is an enhancement, not a bug

Comments

@MicheldeMessieres
Copy link
Contributor

@srajama1 This is for the double/float issue we discussed. We decided to have Amesos2 Umfpack provide a warning that type conversion would take place if built with float on and double off since Umfpack only supports double. So I had these settings:
Trilinos_ENABLE_FLOAT=ON
Tpetra_INST_DOUBLE=OFF
I found that Tpetra will not link with these settings if tests or examples are on - for example TpetraCore_BugTests.exe would not link. With only Amesos2 tests on, there are also link issues. I can build Tpetra and then Amesos2 under these settings with tests and examples off. So we may want to reconfigure things so Tpetra and Amesos2 would build tests/examples under these conditions.

@srajama1
Copy link
Contributor

I think the problem is turning double off, not turning float on.

The larger question is "Should Trilinos work with DOUBLE off ?"

@maherou @kddevin @rppawlo @mperego

@mperego
Copy link
Contributor

mperego commented Mar 16, 2017

In principle think we should be able to compile Trilinos with double off. This would prevent having hard-coded doubles used instead of the requested type.
However I'm not sure how practical it is to do so, especially for the tests.

@mhoemmen
Copy link
Contributor

If people want to be able to shut off Scalar=double, then we could add that as a feature request. Note that enabling Scalar=complex currently requires Scalar=double to be enabled.

@mhoemmen mhoemmen added the type: enhancement Issue is an enhancement, not a bug label Mar 21, 2017
@mhoemmen
Copy link
Contributor

I'm marking this as an "enhancement," since I have never met a Trilinos customer who wanted to shut off Scalar=double in their builds. That doesn't mean it shouldn't work, but it does help us set the priority for making such a thing work.

@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Feb 20, 2021
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

No branches or pull requests

4 participants