Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload updated OSM/Label data #7

Open
Lesstat opened this issue May 12, 2017 · 4 comments
Open

Reload updated OSM/Label data #7

Lesstat opened this issue May 12, 2017 · 4 comments
Assignees
@Marc42
Milestone
Porsche

Comments

@Lesstat
Copy link
Collaborator

Lesstat commented May 12, 2017

No description provided.

@Lesstat Lesstat added this to the Porsche milestone May 12, 2017
@Lesstat Lesstat changed the title Reload updated OSM/ Label data Reload updated OSM/Label data May 13, 2017
@Mechks Mechks closed this as completed in e677f5f May 20, 2017
@Mechks
Copy link
Contributor

Mechks commented May 20, 2017

Im sorry, I used the wrong issue id in the commit

@Mechks Mechks reopened this May 20, 2017
@Mechks
Copy link
Contributor

Mechks commented May 23, 2017 •
edited by Lesstat
Loading

Possibilities for initiating a refresh as discussed:

  • Check if the label file was changed
  • REST call which initiates the reload
    (keep in mind that the osm_label_server may serve several labelfiles, which makes solutions which request an update on the executable complex to implement)

Tasks to do here would be:

  • Implement refresh option
  • Start new label component (check if loading was successful?)
  • Route requests to the new component

@Lesstat Lesstat assigned Lesstat and Marc42 and unassigned Lesstat Jun 13, 2017
@Lesstat
Copy link
Collaborator Author

Lesstat commented Jun 13, 2017

We should not forget to free the datastructure (manually) after the new one is build.

@Marc42
Copy link
Contributor

Marc42 commented Aug 10, 2017

Two minor things for the current version:

  1. If multiple label files are updated at the same time, they are reloaded one after the other. This could be done concurrently.
  2. Sometimes there are two Write-Events for a single modification of a label file. This causes an unneccesary reload. The cause of this is currently unknown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marc42 Marc42

Labels
None yet
Projects
None yet
Milestone
Porsche
Development

No branches or pull requests
3 participants
@Lesstat @Mechks @Marc42