Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for CRLF line terminators #7

Open
josesan9 opened this issue Nov 24, 2018 · 0 comments
Open

support for CRLF line terminators #7

josesan9 opened this issue Nov 24, 2018 · 0 comments

Comments

@josesan9
Copy link

Hi,
The current version does not seem to be able to read files with CRLF terminators.
I think this is causing it to effectively comment out all of the code.
noticed because it worked on the machine I created the files in, but not in any machine that updated the files from github.
I scanned two files for testing, this was the output of the files * command on Ubuntu:

20181123004251_test.sql: ASCII text, with CRLF line terminators
20181124185152_test1.sql: ASCII text

The test.sql file never ran, I forced good and bad SQL, it never created the tables or threw any errors.
The test1.sql always worked just fine.

Both files would show up on the schema_migrations table after running dbmate up.

After changing the line endings from CRLF to LF, test.sql ran as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant