Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_links() does not check for enabled activity types causing significant performance problem #622

Open
thepurpleblob opened this issue Jun 15, 2022 · 0 comments

Comments

@thepurpleblob
Copy link

thepurpleblob commented Jun 15, 2022

Referring to plagiarism/turnitin/lib.php function get_links()

This checks if an activity is a quiz and gets information for the quiz. However, there is no check here whether the quiz activity is enabled in the Turnitin settings. Worse, this appears to be called for each attempt in the quiz (possibly a quiz issue). As the 'load_questions_usage_by_activity()' call is relatively expensive this makes displaying the report incredibly slow.

Real life example - with page size set to show all 140 attempts and plagiarism on, approx 20 minutes. With plagiarism off, approx 30 seconds.

There needs to be a specific check in get_links() to ensure data is not collected for activity types where Turnitin is not enabled.

See also (related) #591

Also related, #593

@thepurpleblob thepurpleblob changed the title get_links() does not check for enabled activity types get_links() does not check for enabled activity types causing significant performance problem Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant