Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WAL as default everywhere #1553

Open
avinassh opened this issue Jul 14, 2024 · 5 comments
Open

Use WAL as default everywhere #1553

avinassh opened this issue Jul 14, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@avinassh
Copy link
Member

Currently, Turso (the platform), libsql-sever, and embedded replicas use WAL mode and it is the only mode supported. However libsql drivers don't have WAL mode as default. Let's change that to use WAL everywhere.

reported here: https://discord.com/channels/933071162680958986/1154725980183732224/1261642078694150144

@avinassh avinassh added the good first issue Good for newcomers label Jul 14, 2024
@imskr
Copy link

imskr commented Jul 20, 2024

Can I work on this? @avinassh please assign me

@avinassh
Copy link
Member Author

@imskr sure! feel free to work on it

I would start with the Rust driver first: https://github.com/tursodatabase/libsql/tree/main/libsql

@imskr
Copy link

imskr commented Jul 22, 2024

Thanks @avinassh I was looking to set

PRAGMA journal_mode = wal

In the rust driver I don't see journal_mode, Can you point me to the right place?

@imskr
Copy link

imskr commented Jul 24, 2024

Any pointer on this @avinassh ?

@avinassh
Copy link
Member Author

I don't think it is that simple as we don't set any journal mode and use the defaults. I would probably find the methods where we are creating new connections and setup the journal mode appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants